Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make jsoncpp support C++ Builder by default? #269

Closed
gzliudan opened this issue Apr 28, 2015 · 2 comments
Closed

Can you make jsoncpp support C++ Builder by default? #269

gzliudan opened this issue Apr 28, 2015 · 2 comments

Comments

@gzliudan
Copy link

According to Victor Chen's blog(http://www.cppfans.com/sdk/json/jsoncpp.asp), we can use jsoncpp under C++ Builder platform after below two steps:

  1. move below lines to the end of class ValueIteratorBase in the file value.h
public:
ValueIteratorBase();
explicit ValueIteratorBase(const Value::ObjectValues::iterator& current);
  1. add below lines to the file writer.cpp:
#if defined(__BORLANDC__)  
#include <float.h>
#define isfinite _finite
#define snprintf _snprintf
#endif

I have tested jsoncpp under C++ Builder XE5, XE6, XE7, it works fine. Thank victor chen for his smart work.

@cdunn2001
Copy link
Contributor

Of course, we're fine with this change. But note that we cannot guarantee not to break "Borland" in the future. We have CI tests for gcc, clang, and vs only.

@gzliudan
Copy link
Author

I only tested jsoncpp on C++ Builder 32 bit platform, not 64 bit. C++ Builder 64 bit can support C++11, 32 bit can't support C++11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants