ML-DSA macro definition error

[EverTear]

Describe the bug
Several macros in the sig_ml_dsa.h header file are incorrectly defined as kem types.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'src/sig/ml_dsa/sig_ml_dsa.h'
2. Click on 'sig_ml_dsa.h'
3. Scroll down to 'line 20'
4. See error
   #define OQS_SIG_ml_dsa_44_length_ciphertext OQS_SIG_ml_dsa_44_ipd_length_ciphertext
   I think the macro definition here should be
   #define OQS_SIG_ml_dsa_44_length_signature OQS_SIG_ml_dsa_44_ipd_length_signature
   Similarly, there are many similar macro definition errors below.

Expected behavior
At present, the definition of these macros will cause compilation errors. After modification, those algorithms of ML-DSA should be able to be used normally.

Screenshots

Environment (please complete the following information):

• OS: Ubuntu 20.04
• OpenSSL version: 3.4.0
• Compiler version used: gcc 9.4.0
• Build variables used: none
• liboqs version: main branch

[baentsch]

Thanks for this report @EverTear . These defines indeed look misplaced there (tagging @bhess fyi) -- but they should (and in CI also do not) trigger a wrong compilation as they're unused as far as I can see... So what compilation errors are you seeing??

[EverTear]

Thanks for this report @EverTear . These defines indeed look misplaced there (tagging @bhess fyi) -- but they should (and in CI also do not) trigger a wrong compilation as they're unused as far as I can see... So what compilation errors are you seeing??

Sorry for the misunderstanding. The compilation errors I mentioned are not related to compiling the liboqs library itself, but rather occur when using the ML-DSA algorithm provided by the liboqs library. I was writing a test program that calls all algorithms in liboqs, and I encountered an undefined macro error while trying to call some ML-DSA algorithms (due to modifying code from a template). Specifically, the macro OQS_SIG_ml_dsa_44_length_signature is not defined. I checked the header files of liboqs and found these definition errors.

[bhess]

Hi @EverTear, thanks for this report!
The _encaps, _decaps, _ciphertext and _shared_secret macros are misplaced for a signature scheme (ML-DSA). I'll do a PR with a fix.

[bhess]

@EverTear please see PR #1799 with a fix. Would you be able to confirm if this fixes the issue? Thx

[EverTear]

@bhess Thanks, I've confirmed that the issue has been fixed by PR #1799.

[bhess]

Thanks @EverTear !