Fix: move undeclared vars to preconditions in Taskfile.yaml for impro…

[osnabrugge]

As you know, our infrastructure is very similar, so it's been a little too convenient to leverage your hard work. As solid as your code is, unannounced and/or breaking changes come like Murphy's law! Your recent feature to support multiple clusters came right during a rebuild 😅

Although it is a minor contribution, at least it is something. Moving these undeclared vars into preconditions revealed what changed/broke right away. Hopefully it might help others not to spend countless hours spinning up containers to re-run those task files.

This pull request is a hotfix for the .taskfiles directory, specifically it provides higher reliability and an improved debugging experience with human readable error messages. Main task changes:

• .taskfiles/ExternalSecrets/Taskfile.yaml: Removed the cluster variable from the ExternalSecrets task and added a precondition to check if the cluster argument is required. [1] [2]
• .taskfiles/VolSync/Taskfile.yaml: Removed the cluster variable from the VolSync task and added preconditions to check if the cluster argument is required. [1] [2] [3] [4] [5]
• .taskfiles/Flux/Taskfile.yaml: Removed the cluster variable from the vars section of the Flux task. [1] [2]
• .taskfiles/Kubernetes/Taskfile.yaml: Removed the cluster variable from the vars section of the Kubernetes task.
• .taskfiles/Ansible/Taskfile.yaml: Added preconditions to the Ansible task to check if the cluster and playbook arguments are required.

[onedr0p]

Woah, thanks for the changes. This looks great ❤️

[onedr0p]

I just made a few changes post merge: e409cc4

I didn't want to bore you with styling changes so I did it afterwords :)

[osnabrugge]

Woah, thanks for the changes. This looks great ❤️

Thank you for the kind words! In all honesty, it was a little anxiety inducing to submit a code change PR. I might just be motivated to work on some ideas once my cluster restore is finally done :)

I just made a few changes post merge: e409cc4

I didn't want to bore you with styling changes so I did it afterwords :)

Never boring, I am still learning. You do realize that I am now going to thoroughly review? :)

p.s. did you figure out a work around for this? Environment variables from shell takes precedence over task file definition

[onedr0p]

p.s. did you figure out a work around for this? Environment variables from shell takes precedence over task file definition

Nope, looks like I'm going to have to keep using --context for now.