Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI spec missing some default role type #993

Closed
clementdenis opened this issue Mar 20, 2024 · 3 comments
Closed

OpenAPI spec missing some default role type #993

clementdenis opened this issue Mar 20, 2024 · 3 comments
Assignees

Comments

@clementdenis
Copy link
Contributor

Describe the bug?

IGA admin roles ACCESS_CERTIFICATIONS_ADMIN and ACCESS_REQUESTS_ADMIN are missing from the RoleType in the OpenAPI spec, resulting in null value when deserializing.

What is expected to happen?

The enum values should exist and the com.okta.sdk.resource.model.Role instance should contain these values.

What is the actual behavior?

A null value is set in the deserialized com.okta.sdk.resource.model.Role instance.

Reproduction Steps?

Get the roles of user with any of the IGA role admins.

Additional Information?

You should consider enabling enumUnknownDefaultCase in the OpenAPI generator to have a default enum value (still not ideal, but better than a null value).

Java Version

any

SDK Version

15

OS version

No response

@arvindkrishnakumar-okta
Copy link
Contributor

@clementdenis Thanks for posting!

ACCESS_CERTIFICATIONS_ADMIN & ACCESS_REQUESTS_ADMIN role types are currently missing from spec because they are not GA (Generally Available) yet (from Okta core API's side). These are in EA (Early Access) stage presently, and will be added to spec when they are GA.

@clementdenis
Copy link
Contributor Author

Thanks for the quick answer! However, would you still consider adding the enumUnknownDefaultCase flag to the OpenAPI generation. It will avoid NPE in consumer code when unknown enums are encountered.

@arvindkrishnakumar-okta
Copy link
Contributor

@clementdenis Yes, noted and will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants