Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Page Does Not Correctly Account For Skipped Bans #2647

Open
salmarnir opened this issue Aug 20, 2020 · 1 comment
Open

Draft Page Does Not Correctly Account For Skipped Bans #2647

salmarnir opened this issue Aug 20, 2020 · 1 comment

Comments

@salmarnir
Copy link

salmarnir commented Aug 20, 2020

Current Behavior
In Captain's Mode games (and presumably Captain's Draft), if a team lets the time expire during a ban phase, they essentially skip that ban. However in the draft tab on OpenDota, this is not correctly captured. It instead appears to assign whatever the next hero that was picked or banned to that slot, regardless of which team chose it. This will also cause subsequent picks/bans to be misaligned and results in the page having incorrect and incomplete information. Note that this also affects the time used/time remaining shown at each pick.

Expected behavior/code
Rather than assigning each hero picked/banned in the draft to what it expects the next available "slot" to be, should also parse which team picked or banned the hero to take skipped bans into consideration.

Additional context/Screenshots
For an example of this, please see https://www.opendota.com/matches/5293089497/draft

@howardchung
Copy link
Member

howardchung commented Aug 21, 2020

The data looks like:

"picks_bans": [
{
"is_pick": false,
"hero_id": 57,
"team": 1,
"order": 0
},
{
"is_pick": false,
"hero_id": 89,
"team": 1,
"order": 1
},
{
"is_pick": false,
"hero_id": 82,
"team": 1,
"order": 2
},
{
"is_pick": true,
"hero_id": 68,
"team": 1,
"order": 3
},
{
"is_pick": true,
"hero_id": 87,
"team": 0,
"order": 4
},
{
"is_pick": true,
"hero_id": 7,
"team": 0,
"order": 5
},
{
"is_pick": true,
"hero_id": 71,
"team": 1,
"order": 6
},
"hero_id": 68,
"team": 1,
"order": 3
},

I think we have to update the drafts page to account for the team picking rather than having a set order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants