Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton Loaders should mimic the /matches pages more accurately #2069

Open
Argn0 opened this issue Mar 14, 2019 · 3 comments
Open

Skeleton Loaders should mimic the /matches pages more accurately #2069

Argn0 opened this issue Mar 14, 2019 · 3 comments

Comments

@Argn0
Copy link
Contributor

Argn0 commented Mar 14, 2019

This would increase their effectiveness in shortening the perceived loading times.
Especially the /matches/overview page would benefit from this.

http://danilowoz.com/create-content-loader/ is a useful tool for this task.

@bdbch
Copy link
Member

bdbch commented Oct 7, 2019

We could also use @material-ui's component:
https://material-ui.com/components/skeleton

Should be easy to render table item with a loading state.

@howardchung
Copy link
Member

I do like how react-content-loader allows custom loaders that you build yourself. Is the material-ui version as flexible?

@bdbch
Copy link
Member

bdbch commented Oct 8, 2019

The material-ui skeleton component can also be arranged as needed. They support multiple options like

<Skeleton variant="rect" /> - which will render a rectangle with a specific width and height
<Skeleton /> - which will be rendered as a line of text with a specific width

Take a look at this example (Facebook Post) to see how they use CSS + the Skeleton Loader component to adjust the styling for the loading elements:

https://material-ui.com/components/skeleton/#facebook-example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants