Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile language feature request #153

Open
pkhubpp8 opened this issue Aug 5, 2019 · 4 comments
Open

mobile language feature request #153

pkhubpp8 opened this issue Aug 5, 2019 · 4 comments

Comments

@pkhubpp8
Copy link

pkhubpp8 commented Aug 5, 2019

  • issue

Screenshot_2019-08-06-01-11-02-564_org mozilla firefox
Screenshot_2019-08-06-01-10-43-333_com opendota mobile

here is the same match snapshot in app and web site. But it is chinese on web page and english on mobile app view.

  • expect
    language setting is supported on app

  • actually
    lanuage setting on web page is supported, but app not support yet

@howardchung
Copy link
Member

@Proyoyo do you know if some strings aren't localized in the app?

@Proyoyo
Copy link
Contributor

Proyoyo commented Aug 6, 2019

@howardchung
Localization hasn't been implemented on the app yet.

@howardchung
Copy link
Member

Ah, that explains it. Are the strings in loc files and just not translated, or are they still inlined in the code?

@Proyoyo
Copy link
Contributor

Proyoyo commented Aug 6, 2019

They are still inlined in the code at the moment.

@howardchung howardchung transferred this issue from odota/web Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants