Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.json and yarn.lock #120

Closed
cs-miller opened this issue Mar 6, 2018 · 3 comments
Closed

package-lock.json and yarn.lock #120

cs-miller opened this issue Mar 6, 2018 · 3 comments

Comments

@cs-miller
Copy link
Contributor

as far as I know, these two lockfiles are not automatically kept in sync, i.e. yarn does not modify package-lock when it adds a dependency. Perhaps it is better to just settle on using one or the other?

@keatongreve
Copy link

+1 to that! It would also be important to create a CONTRIBUTING doc so you can document that one package manager is the preferred for this project, as well as making sure that anyone that wants to contribute with a pull request needs update the preferred lockfile before it can be merged.

FWIW, I really like yarn but I'm usually in favor of keeping npm as the standard for OSS projects, because it is inherently more popular.

@Proyoyo
Copy link
Contributor

Proyoyo commented Mar 7, 2018

Personally I've been using npm. However, I have no strong preference for any of the two. Should we use npm because it's what Facebook uses in the React Native tutorial?

@cs-miller
Copy link
Contributor Author

Up to you, just better to pick one and stick with it (afaik) (and delete the unused lockfile).

@Proyoyo Proyoyo closed this as completed in 5347f9f Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants