Add timestamps for Boots of Travel combination

[Galvain]

In match info there is no timestamp for Boots of Travel 1 or 2 combining.

[howardchung]

What combining are you referring to? The item is considered purchased when the recipe is bought, right?

[Galvain]

I'm referring to when the hero gets both combines both components in their inventory.

eg in: https://www.opendota.com/matches/5772722561/purchases

Last component for pudge's aghanim's scepter is purchased at 28:29, but the full item is combined in the inventory at 28:45

There is no timestamp for either the Boots of Travel 1 or 2 upgrades for the same hero.

[howardchung]

Hmm, looks like there is no new item logged in the purchase logs when travels are created. We usually filter out recipe purchases, but might have to make an exception in this case

[builder-247]

Hmm, looks like there is no new item logged in the purchase logs when travels are created. We usually filter out recipe purchases, but might have to make an exception in this case

Perhaps we should just add purchase event for the respective boots of travel?

[howardchung]

How do you proposed we do that?

[builder-247]

How do you proposed we do that?

Adding an else if contains boots of travel id here, and then replacing the recipe part of the ID

core/processors/processExpand.js

Line 280 in 461a5cb

if (key.indexOf('recipe_') !== 0) {

[howardchung]

hmm yeah I guess that would work. It might cause a duplicate event if we ever reparse old pro games?

[builder-247]

hmm yeah I guess that would work. It might cause a duplicate event if we ever reparse old pro games?

What are you referring to?

I tested on a recent match and it works as intended, can do further tests as well.

[builder-247]

On a second thought it might be better to just include the recipe, since there are many edge cases - making this more suitable for web to sort out.

[howardchung]

What I mean is that old replays emitted a purchase event for boots of travel. So if we converted the recipe purchase to an item purchase we would see two purchase events