Add dotaplus xp #2145
Add dotaplus xp #2145
Conversation
|
The |
| @@ -472,6 +472,10 @@ You can find data that can be used to convert hero and ability IDs and other inf | |||
| description: 'The ID value of the hero played', | |||
| type: 'integer', | |||
| }, | |||
| hero_dotaplus_xp: { | |||
There was a problem hiding this comment.
Would this make more sense stored as a separate table from each player_hero combination? Seems like this would be a properly that's independent of each match, unless we care about their dota plus level at the time of the match.
There was a problem hiding this comment.
This is how the game client displays it, also not sure if gets set to 0 on the replays if the player doesn't have a valid subscription anymore
|
I'm going to add the data to more endpoints that requires more research on the codebase. |
| @@ -150,6 +151,7 @@ CREATE TABLE IF NOT EXISTS player_caches ( | |||
| gold_per_min text, | |||
| xp_per_min text, | |||
| hero_id text, | |||
| hero_dotaplus_xp text, | |||
There was a problem hiding this comment.
we only need it in the table if we are going to aggregate this across matches for a player
routes/spec.js
Outdated
| @@ -1534,6 +1543,8 @@ You can find data that can be used to convert hero and ability IDs and other inf | |||
| heroes[tmHero].against_games += 1; | |||
| heroes[tmHero].against_win += playerWin ? 1 : 0; | |||
| } | |||
| // Use the highest xp value | |||
| heroes[tmHero].hero_dotaplus_xp = Math.max(m.hero_dotaplus_xp, heroes[tmHero].hero_dotaplus_xp); | |||
There was a problem hiding this comment.
don't think this is necessary, isn't heroes just the object that tracks the heroes played with?
There was a problem hiding this comment.
oh i see, looks like you're adding it here to display the hero level for all of a player's heroes
| @@ -21,6 +21,7 @@ function getParseSchema() { | |||
| radiant_gold_adv: [], | |||
| radiant_xp_adv: [], | |||
| cosmetics: {}, | |||
| dotaplus: {}, | |||
There was a problem hiding this comment.
Maybe we should store this as a field per player instead of per match? since we need to store it per player in the player_caches table anyway
Closes #1864
Changes
This PR adds
hero_dotaplus_xpfield to both/player/matches/{match}and/player/heroesendpoints