Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add assists_log and deathes_log to table<player_matches>, just like kills_log. #1465

Open
heqiuzhi opened this issue May 19, 2017 · 6 comments
Labels
Milestone

Comments

@heqiuzhi
Copy link

table<player_matches> has kills_log——eg. ([{"time":281,"key":"npc_dota_hero_dark_seer"},{"time":755,"key":"npc_dota_hero_slardar"}])

It's really nice!
Can you add assists_log and deathes_log too? Thanks! # @

@howardchung
Copy link
Member

Unfortunately the combat log doesn't indicate assists.

You should be able to compute deaths by reading all of the kills_logs and working backwards.

@heqiuzhi
Copy link
Author

Dotabuff
qq 20170520083509
image

Can you get the assist info by reading death_log and damage_log in combat log?
Kills_log alone (without assist_info) is useless !
Thanks.

@howardchung
Copy link
Member

I think this is from reading the CHAT_EVENT_HERO_KILL events. Can look into it.

@heqiuzhi
Copy link
Author

How can I get the CHAT_EVENT_HERO_KILL events ? Is there any API ?
I don't want to parse the replay myself .

@howardchung
Copy link
Member

That data's part of the replay, so you'll have to parse it or make a pull request to odota/parser to extract and store the data so it can be delivered over the API.

@howardchung howardchung modified the milestone: Backlog Jun 7, 2017
@dota2heqiuzhi
Copy link

any update?
I also need the details of death log(like dotabuff)
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants