Update fsevent dependencies #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a WIP? It doesn't build at all. |
|
Weird, it built for me on linux and macos, I'll have a look |
|
Ok, that's funy, it doesn't fail on macos but it fails if I cross compile from linux... i'll fix this |
|
Does the test suite fail for you locally? I'll retry the run in CI to see if it's intermittent anyway. Otherwise, looks good. That will get into 5.0. For the current major, would you be willing to also write this for the |
|
This looks intermittent. Was it already like that before ? Maybe some time behavior changed and needs adjustment ? |
|
Fsevents tests are awful and often intermittent, this is known :)
…On Tue, 7 May 2019, 11:43 Bastien Orivel, ***@***.***> wrote:
This looks intermittent. Was it already like that before ? Maybe some time
behavior changed and needs adjustment ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#195 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABGBC37Z4QH6GMDJUSIIALPUC7ANANCNFSM4HLDP5UQ>
.
|
|
Ok, I'll make a PR against the |
From notify-rs#196 Co-authored-by: Bastien Orivel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will dedupe quite a few dependencies in crates using notify. I didn't bump the version because I don't know if any breaking change mad it to the branch but I'd be more than happy to do so if you want