Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: take co-authors into account in find-inactive-collaborators #52669

Merged
merged 1 commit into from
Apr 26, 2024
Merged

tools: take co-authors into account in find-inactive-collaborators #52669

merged 1 commit into from
Apr 26, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 24, 2024

Also switch to using git built-in trailers parser instead of a regex, which should be more reliable.

@aduh95 aduh95 requested a review from Trott April 24, 2024 19:51
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 24, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 24, 2024
mhdawson
mhdawson approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit 1d455bc into nodejs:main Apr 26, 2024
29 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1d455bc

@aduh95 aduh95 deleted the find-inactive-co-authors branch April 26, 2024 19:59
aduh95 added a commit that referenced this pull request Apr 29, 2024
@aduh95
tools: take co-authors into account in find-inactive-collaborators
db421bd 
PR-URL: #52669
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@aduh95 @marco-ippolito
tools: take co-authors into account in find-inactive-collaborators
93ceb03 
PR-URL: #52669
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@aduh95 @marco-ippolito
tools: take co-authors into account in find-inactive-collaborators
c925bc1 
PR-URL: #52669
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@aduh95 @EliphazBouye
tools: take co-authors into account in find-inactive-collaborators
3cebe3f 
PR-URL: nodejs#52669
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@aduh95 @bmeck
tools: take co-authors into account in find-inactive-collaborators
c9f521d 
PR-URL: nodejs#52669
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@anonrig anonrig anonrig approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

@trivikr trivikr trivikr approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.