Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toosl: fix error reported by coverity in js2c.cc #52142

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Coverity reported using the wrong argument types
to printf

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 18, 2024
@mhdawson
Copy link
Member Author

reports from coverity

}
614
615  if (simplified_count > 0) {
     	CID 347888:Invalid type in argument to printf format specifier (PRINTF_ARGS) [ "select issue" ]
616    Debug("Simplified %d characters, ", simplified_count);
     	
CID 347889: (#1 of 1): Invalid type in argument to printf format specifier (PRINTF_ARGS)
invalid_type: Argument code_size to format specifier %d was expected to have type int but has type unsigned long.["show details"]
     	CID 347887:Invalid type in argument to printf format specifier (PRINTF_ARGS) [ "select issue" ]
617    Debug("old size %d, new size %d\n", code_size, simplified->size());
618    return true;
619  }
620  return false;

Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <[email protected]>
@meyfa
Copy link
Contributor

meyfa commented Mar 19, 2024

There's a typo in the PR title 😅

@mhdawson
Copy link
Member Author

@meyfa had already fixed the typo in the commit, but just fixed in the PR title.

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

mhdawson added a commit that referenced this pull request Mar 25, 2024
Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52142
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mhdawson
Copy link
Member Author

Landed in Landed in c43a944

@mhdawson mhdawson closed this Mar 25, 2024
anonrig pushed a commit to anonrig/node that referenced this pull request Mar 25, 2024
Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52142
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52142
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52142
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
Coverity reported using the wrong argument types
to printf

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52142
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants