Remove snapshot.blob from 18.x branch #46133
Comments
|
@danielleadams It looks like this was done when backporting 15f1051 on the v18.x branch in 2c0f7d4. It looks like something went wrong with the backport as the |
|
I suppose it should go into .gitignore |
|
Do you want to send a PR? |
|
Not really, other fish to fry |
|
This is my first contribution to open source, i would love to work on this if this is something a beginner can do. |
|
This is my first contribution to open source, i would love to work on this if this is something a beginner can do.
Sure go ahead, and let us know if you get stuck!
|
|
Alright sir. |
|
Due to inactivity I'll proceed to fix this |
juanarbol
added a commit
to juanarbol/node
that referenced
this issue
Feb 12, 2023
The `snapshot.blob` file landed while backporting nodejs@2c0f7d4 in the v18.x release line, but is not required Fixes: nodejs#46133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
18.13.0
Platform
No response
Subsystem
No response
What steps will reproduce the bug?
No response
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior?
Build artifacts shouldn't be in git repository, nor in the release tarball.
What do you see instead?
./snapshot.blob is in the git repository (branch 18.x) and in the release tarball of nodejs 18.13.0
Additional information
No response
The text was updated successfully, but these errors were encountered: