Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs.appendFileSync results in an abort in v10.x #38194

Closed
zyscoder opened this issue Apr 11, 2021 · 1 comment
Closed

fs.appendFileSync results in an abort in v10.x #38194

zyscoder opened this issue Apr 11, 2021 · 1 comment
Labels
fs Issues and PRs related to the fs subsystem / file system.

Comments

@zyscoder
Copy link

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

fs.appendFileSync(2147483648,null,null);

Then the node instance occurs an abort.
In my practice, v12.x and v14.x would not trigger this abort.
The abort is similar with #38193.

How often does it reproduce? Is there a required condition?

This abort can always be triggered following the steps above.

What is the expected behavior?

If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node
> fs.appendFileSync(2147483648,null,null);
/home/zys/Toolchains/node-v10.24.0/node[42370]: ../src/node_file.cc:1719:void node::fs::WriteBuffer(const FunctionCallbackInfo<v8::Value> &): Assertion `args[0]->IsInt32()' failed.
 1: 0x17c3524 node::DumpBacktrace(_IO_FILE*) [/home/zys/Toolchains/node-v10.24.0/node]
 2: 0x1818dbe node::Abort() [/home/zys/Toolchains/node-v10.24.0/node]
 3: 0x1816245  [/home/zys/Toolchains/node-v10.24.0/node]
 4: 0x18ba50f  [/home/zys/Toolchains/node-v10.24.0/node]
 5: 0x1ec8fe9 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/home/zys/Toolchains/node-v10.24.0/node]
 6: 0x1ec67fa  [/home/zys/Toolchains/node-v10.24.0/node]
 7: 0x1ec4538  [/home/zys/Toolchains/node-v10.24.0/node]
 8: 0x7ee39e65bf3d 
[1]    42370 abort (core dumped)  /home/zys/Toolchains/node-v10.24.0/node

Additional information

@Ayase-252 Ayase-252 added fs Issues and PRs related to the fs subsystem / file system. v10.x labels Apr 11, 2021
@targos
Copy link
Member

targos commented Apr 11, 2021

@zyscoder we appreciate you opening these issues, but they are not going to be fixed for Node.js v10.x. That release line is in Maintenance and can only get critical bug fixes and security patches.

@targos targos closed this as completed Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

No branches or pull requests

3 participants