Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: node crashes when Runtime.evaluate with timeout is called #22203

Closed
alexkozy opened this issue Aug 9, 2018 · 2 comments
Closed

inspector: node crashes when Runtime.evaluate with timeout is called #22203

alexkozy opened this issue Aug 9, 2018 · 2 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@alexkozy
Copy link
Member

alexkozy commented Aug 9, 2018

  • Version: v11.pre (built from master branch)
  • Platform: Mac OS
  • Subsystem: inspector

On attempt to run Runtime.evaluate with timeout flag (ndb and DevTools frontend use this flag for eager evaluation without side effects) Node crashes somewhere around NodePlatform::CallOnForegroundThread method. On Inspector side we call postTask on current platform, most likely current platform is incorrect.

I will debug this issue by myself later this week.
@alexkozy
Copy link
Member Author

alexkozy commented Aug 9, 2018

/cc @eugeneo

@mscdex
Copy link
Contributor

mscdex commented Aug 9, 2018

Duplicate of #22157

@mscdex mscdex added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Aug 9, 2018
@mscdex mscdex marked this as a duplicate of #22157 Aug 9, 2018
@mscdex mscdex closed this as completed Aug 9, 2018
jdalton referenced this issue Aug 21, 2018
@alexkozy
src: implement v8::Platform::CallDelayedOnWorkerThread
b1e2612 
This method is crucial for Runtime.evaluate protocol command with
timeout flag. At least Chrome DevTools frontend uses this method for
every execution in console.

PR-URL: #22383
Fixes: #22157
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @alexkozy