Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b1e26128f317a6f5a5808a0a727e98f80f088b84
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 36696cfe8479f3fd511124b60c24b4a6a33a80da
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Aug 21, 2018

  1. test: fix flaky http timeout test

    There is no guarantee that a timeout won't be delayed considerably due
    to unrelated activity on the host. Instead of checking that the timeout
    happens within a certain tolerance, simply check that it did not happen
    too soon.
    
    Fixes: #22041
    
    PR-URL: #22403
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    fd76a3d View commit details
    Browse the repository at this point in the history
  2. test: move http timeout test to parallel

    test-http-client-timeout-option-with-agent no longer checks that the
    timeout happens within a certain tolerance so it can be moved to the
    parallel test suite.
    
    PR-URL: #22403
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    4b71b01 View commit details
    Browse the repository at this point in the history
  3. test: improve assert message in http timeout test

    PR-URL: #22403
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    36696cf View commit details
    Browse the repository at this point in the history
Loading