-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Comparing changes
Open a pull request
base repository: nodejs/node
base: 5d910ca389b3e1b956a3e888a710dff81b524958
head repository: nodejs/node
compare: 6f3a8b45a5f02aa87987a0a2ea48c74fefa9fcc6
- 20 commits
- 28 files changed
- 5 contributors
Commits on Jul 12, 2023
-
url: remove unused
kFormat
from urlPR-URL: #46867 Backport-PR-URL: #48345 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3db235b - Browse repository at this point
Copy the full SHA 3db235bView commit details -
url: offload
URLSearchParams
initializationPR-URL: #46867 Backport-PR-URL: #48345 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c79e1b7 - Browse repository at this point
Copy the full SHA c79e1b7View commit details -
url: set
formatUrl
method as no side effectPR-URL: #46884 Backport-PR-URL: #48345 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aa4f485 - Browse repository at this point
Copy the full SHA aa4f485View commit details -
url: backport non-major changes from #46904
PR-URL: #46904 Backport-PR-URL: #48345 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f495cb6 - Browse repository at this point
Copy the full SHA f495cb6View commit details -
url: allow extension of user provided URL objects
PR-URL: #46989 Backport-PR-URL: #48345 Fixes: #46981 Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4784e64 - Browse repository at this point
Copy the full SHA 4784e64View commit details -
url: fix array overrun in node:url::SetArgs()
PR-URL: #47001 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 977a8ba - Browse repository at this point
Copy the full SHA 977a8baView commit details -
src: use std::array for passing argv in node::url
Implements a review suggestion from 72e971e. Refs: #47001 (comment) PR-URL: #47035 Backport-PR-URL: #48345 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1f2c91f - Browse repository at this point
Copy the full SHA 1f2c91fView commit details -
PR-URL: #47179 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 11f48e0 - Browse repository at this point
Copy the full SHA 11f48e0View commit details -
PR-URL: #47339 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 96c50ba - Browse repository at this point
Copy the full SHA 96c50baView commit details -
url: use ada::url_aggregator for parsing urls
PR-URL: #47339 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b395b16 - Browse repository at this point
Copy the full SHA b395b16View commit details -
url: drop ICU requirement for parsing hostnames
PR-URL: #47339 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0dc485e - Browse repository at this point
Copy the full SHA 0dc485eView commit details -
url: handle URL.canParse without base parameter
PR-URL: #47547 Backport-PR-URL: #48345 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8897305 - Browse repository at this point
Copy the full SHA 8897305View commit details -
PR-URL: #47598 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 08dd271 - Browse repository at this point
Copy the full SHA 08dd271View commit details -
PR-URL: #47678 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 42e690f - Browse repository at this point
Copy the full SHA 42e690fView commit details -
PR-URL: #47737 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2d03d5f - Browse repository at this point
Copy the full SHA 2d03d5fView commit details -
PR-URL: #47893 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 575ddf6 - Browse repository at this point
Copy the full SHA 575ddf6View commit details -
PR-URL: #47922 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 81b514d - Browse repository at this point
Copy the full SHA 81b514dView commit details -
PR-URL: #48036 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4ee1f6 - Browse repository at this point
Copy the full SHA a4ee1f6View commit details -
PR-URL: #48092 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 075b6db - Browse repository at this point
Copy the full SHA 075b6dbView commit details -
PR-URL: #48223 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6f3a8b4 - Browse repository at this point
Copy the full SHA 6f3a8b4View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5d910ca389b3e1b956a3e888a710dff81b524958...6f3a8b45a5f02aa87987a0a2ea48c74fefa9fcc6