Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3438f4b2cab572b4e21ed68013f2b25adf911e8b
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 263d13766f08fb3444c205ce7ecaaa3efd89546a
Choose a head ref
  • 3 commits
  • 10 files changed
  • 1 contributor

Commits on Dec 20, 2018

  1. src: move GetOpenSSLVersion into node_metadata.cc 

    Instead of implementing it in node_crypto.cc even though the only
place that needs it is the `Metadata::Versions` constructor.

PR-URL: #25115
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @joyeecheung
    joyeecheung committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    e970361 View commit details
    Browse the repository at this point in the history

  2. src: move the declaration of http parser versions into node_metadata.h 

    Instead of putting them in node_internals.h.

PR-URL: #25115
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @joyeecheung
    joyeecheung committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    a29c93a View commit details
    Browse the repository at this point in the history

  3. src: initialize ICU version in per_process::metadata.versions 

    Instead of

- Initialize the ICU versions in JS land after consulting
  internalBinding('config').hasIntl
- Joining the version keys in C++
- Splitting the keys in JS and call into C++ again to get the value for
  each of the keys

Do:

- Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT`
- Do the initialization in C++ right after ICU data is loaded
- Initialize each version directly using ICU functions/constants,
  and put them in per_process::metadata.versions. These will be
  copied into `process.versions` naturally later.
  This way, the initialization of the versions won't be called
  in worker threads again.

PR-URL: #25115
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @joyeecheung
    joyeecheung committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    263d137 View commit details
    Browse the repository at this point in the history
Loading