Skip to content

Commit

Permalink
test: improve test-child-process-exec-buffer
Browse files Browse the repository at this point in the history
* use const instead of var for required modules
* use assert.strictEqual instead of assert.equal
* use assert.strictEqual instead of assert.ok

PR-URL: #10275
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
  • Loading branch information
edsadr authored and italoacasas committed Dec 18, 2016
1 parent 4a25756 commit f7f662c
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions test/parallel/test-child-process-exec-buffer.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,24 @@
'use strict';
const common = require('../common');
var assert = require('assert');
var exec = require('child_process').exec;
var os = require('os');
var str = 'hello';
const assert = require('assert');
const exec = require('child_process').exec;
const os = require('os');
const str = 'hello';

// default encoding
exec('echo ' + str, common.mustCall(function(err, stdout, stderr) {
assert.ok('string', typeof stdout, 'Expected stdout to be a string');
assert.ok('string', typeof stderr, 'Expected stderr to be a string');
assert.equal(str + os.EOL, stdout);
assert.strictEqual(typeof stdout, 'string', 'Expected stdout to be a string');
assert.strictEqual(typeof stderr, 'string', 'Expected stderr to be a string');
assert.strictEqual(str + os.EOL, stdout);
}));

// no encoding (Buffers expected)
exec('echo ' + str, {
encoding: null
}, common.mustCall(function(err, stdout, stderr) {
assert.ok(stdout instanceof Buffer, 'Expected stdout to be a Buffer');
assert.ok(stderr instanceof Buffer, 'Expected stderr to be a Buffer');
assert.equal(str + os.EOL, stdout.toString());
assert.strictEqual(stdout instanceof Buffer, true,
'Expected stdout to be a Buffer');
assert.strictEqual(stderr instanceof Buffer, true,
'Expected stderr to be a Buffer');
assert.strictEqual(str + os.EOL, stdout.toString());
}));

0 comments on commit f7f662c

Please sign in to comment.