From d74bda42413ebf134bdab5339291807a29b0bceb Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Sat, 18 May 2024 04:50:47 -0400 Subject: [PATCH] test: add AbortController to knownGlobals PR-URL: https://github.com/nodejs/node/pull/53020 Reviewed-By: Moshe Atlow Reviewed-By: Chengzhong Wu Reviewed-By: Marco Ippolito Reviewed-By: Richard Lau Reviewed-By: Benjamin Gruenbaum --- test/common/index.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/test/common/index.js b/test/common/index.js index 6ef229797c8f77..7e40ab40da96bd 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -280,6 +280,7 @@ function platformTimeout(ms) { } let knownGlobals = [ + AbortController, atob, btoa, clearImmediate, @@ -292,15 +293,6 @@ let knownGlobals = [ queueMicrotask, ]; -// TODO(@jasnell): This check can be temporary. AbortController is -// not currently supported in either Node.js 12 or 10, making it -// difficult to run tests comparatively on those versions. Once -// all supported versions have AbortController as a global, this -// check can be removed and AbortController can be added to the -// knownGlobals list above. -if (global.AbortController) - knownGlobals.push(global.AbortController); - if (global.gc) { knownGlobals.push(global.gc); }