buffer: expose Blob as a global

`Blob` is defined as a global in the spec. We have WPT's for it, and it's graduated experimental. Time to expose it as a global. Signed-off-by: James M Snell <[email protected]> PR-URL: #41270 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
nodejs · Dec 24, 2021 · cea76db · cea76db
1 parent 99c18f4
commit cea76db
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 1 deletion.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -363,6 +363,7 @@ module.exports = {
     BigInt: 'readable',
     BigInt64Array: 'readable',
     BigUint64Array: 'readable',
+    Blob: 'readable',
     DOMException: 'readable',
     Event: 'readable',
     EventTarget: 'readable',

diff --git a/doc/api/buffer.md b/doc/api/buffer.md
@@ -458,7 +458,7 @@ added:
   - v14.18.0
 changes:
   - version: REPLACEME
-    pr-url: https://github.com/nodejs/node/pull/00000
+    pr-url: https://github.com/nodejs/node/pull/41270
     description: No longer experimental.
 -->
 

diff --git a/doc/api/globals.md b/doc/api/globals.md
@@ -199,6 +199,16 @@ added: v17.3.0
 
 If `abortSignal.aborted` is `true`, throws `abortSignal.reason`.
 
+## Class: `Blob`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+<!-- type=global -->
+
+See {Blob}.
+
 ## Class: `Buffer`
 
 <!-- YAML

diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -37,6 +37,8 @@ rules:
       # disabled with --no-harmony-atomics CLI flag.
     - name: Atomics
       message: "Use `const { Atomics } = globalThis;` instead of the global."
+    - name: Blob
+      message: "Use `const { Blob } = require('buffer');` instead of the global."
     - name: Buffer
       message: "Use `const { Buffer } = require('buffer');` instead of the global."
     - name: DOMException

diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -444,6 +444,7 @@ function setupGlobalProxy() {
 
 function setupBuffer() {
   const {
+    Blob,
     Buffer,
     atob,
     btoa,
@@ -456,6 +457,12 @@ function setupBuffer() {
   delete bufferBinding.zeroFill;
 
   ObjectDefineProperties(globalThis, {
+    'Blob': {
+      value: Blob,
+      enumerable: false,
+      writable: true,
+      configurable: true,
+    },
     'Buffer': {
       value: Buffer,
       enumerable: false,