Skip to content

Commit

Permalink
build: don't build icu with -fno-rtti
Browse files Browse the repository at this point in the history
ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.

Fixes: #8867
PR-URL: #8886
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
  • Loading branch information
bnoordhuis authored and Fishrock123 committed Oct 11, 2016
1 parent 31232ad commit a202be6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/icu/icu-generic.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
[ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
'cflags': [ '-Wno-deprecated-declarations' ],
'cflags_cc': [ '-frtti' ],
'cflags_cc!': [ '-fno-rtti' ],
}],
[ 'OS == "mac" or OS == "ios"', {
'xcode_settings': {'GCC_ENABLE_CPP_RTTI': 'YES' },
Expand Down

0 comments on commit a202be6

Please sign in to comment.