Skip to content

Commit

Permalink
buffer: remove unnecessary TODO comments
Browse files Browse the repository at this point in the history
Refs: #4642
PR-URL: #4719
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
  • Loading branch information
pgeiss authored and cjihrig committed Jan 17, 2016
1 parent da550aa commit 83d2b77
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -523,8 +523,6 @@ Buffer.prototype.fill = function fill(val, start, end) {
};


// TODO(trevnorris): fix these checks to follow new standard
// write(string, offset = 0, length = buffer.length, encoding = 'utf8')
var writeWarned = false;
const writeMsg = 'Buffer.write(string, encoding, offset, length) is ' +
'deprecated. Use write(string[, offset[, length]]' +
Expand Down Expand Up @@ -617,8 +615,6 @@ Buffer.prototype.toJSON = function() {
};


// TODO(trevnorris): currently works like Array.prototype.slice(), which
// doesn't follow the new standard for throwing on out of range indexes.
Buffer.prototype.slice = function slice(start, end) {
const buffer = this.subarray(start, end);
Object.setPrototypeOf(buffer, Buffer.prototype);
Expand Down

0 comments on commit 83d2b77

Please sign in to comment.