Skip to content

Commit

Permalink
src: fix deprecation id for non-string env value
Browse files Browse the repository at this point in the history
This is a follow-up of #18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.

PR-URL: #19209
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
thefourtheye authored and TimothyGu committed Mar 7, 2018
1 parent 5826fe4 commit 50b1cb3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2667,7 +2667,7 @@ static void EnvSetter(Local<Name> property,
"Assigning any value other than a string, number, or boolean to a "
"process.env property is deprecated. Please make sure to convert the "
"value to a string before setting process.env with it.",
"DEP00XX").IsNothing())
"DEP0104").IsNothing())
return;
}
#ifdef __POSIX__
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-process-env-deprecation.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ common.expectWarning(
'Assigning any value other than a string, number, or boolean to a ' +
'process.env property is deprecated. Please make sure to convert the value ' +
'to a string before setting process.env with it.',
'DEP00XX'
'DEP0104'
);

process.env.ABC = undefined;
Expand Down

0 comments on commit 50b1cb3

Please sign in to comment.