Skip to content

Commit

Permalink
doc: correct vcbuild options for windows testing
Browse files Browse the repository at this point in the history
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: #10686
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
  • Loading branch information
jboarman authored and italoacasas committed Jan 27, 2017
1 parent 8314d9e commit 3f17757
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ Prerequisites:
To run the tests:

```console
> .\vcbuild test
> .\vcbuild nosign test
```

To test if Node.js was built correctly:
Expand Down Expand Up @@ -180,7 +180,7 @@ $ ./configure --with-intl=full-icu --download=all
##### Windows:

```console
> .\vcbuild full-icu download-all
> .\vcbuild nosign full-icu download-all
```

#### Building without Intl support
Expand All @@ -197,7 +197,7 @@ $ ./configure --without-intl
##### Windows:

```console
> .\vcbuild without-intl
> .\vcbuild nosign without-intl
```

#### Use existing installed ICU (Unix / OS X only):
Expand Down Expand Up @@ -240,7 +240,7 @@ First unpack latest ICU to `deps/icu`
as `deps/icu` (You'll have: `deps/icu/source/...`)

```console
> .\vcbuild full-icu
> .\vcbuild nosign full-icu
```

## Building Node.js with FIPS-compliant OpenSSL
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,19 +170,19 @@ $ ./configure && make -j4 test
Windows:

```text
> vcbuild test
.\vcbuild nosign test
```

(See the [BUILDING.md](./BUILDING.md) for more details.)

Make sure the linter is happy and that all tests pass. Please, do not submit
patches that fail either check.

Running `make test`/`vcbuild test` will run the linter as well unless one or
Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
more tests fail.

If you want to run the linter without running tests, use
`make lint`/`vcbuild jslint`.
`make lint`/`.\vcbuild nosign jslint`.

If you are updating tests and just want to run a single test to check it, you
can use this syntax to run it exactly as the test harness would:
Expand Down

0 comments on commit 3f17757

Please sign in to comment.