Skip to content

Commit

Permalink
test: move slower tests into pummel and skip on slow devices
Browse files Browse the repository at this point in the history
Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: #34289 (comment)

PR-URL: #38395
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
  • Loading branch information
Trott authored and targos committed Apr 29, 2021
1 parent 45322df commit 231ef4b
Show file tree
Hide file tree
Showing 5 changed files with 38 additions and 5 deletions.
12 changes: 10 additions & 2 deletions test/pummel/test-fs-watch-system-limit.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,18 @@ const child_process = require('child_process');
const fs = require('fs');
const stream = require('stream');

if (!common.isLinux)
if (!common.isLinux) {
common.skip('The fs watch limit is OS-dependent');
if (!common.enoughTestCpu)
}

if (!common.enoughTestCpu) {
common.skip('This test is resource-intensive');
}

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

try {
// Ensure inotify limit is low enough for the test to actually exercise the
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
'use strict';

require('../common');
const common = require('../common');

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const { spawnSync } = require('child_process');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
'use strict';

const common = require('../common');

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const { spawnSync } = require('child_process');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,15 @@
'use strict';

const common = require('../common');
if (process.config.variables.asan)

if (process.config.variables.asan) {
common.skip('ASAN messes with memory measurements');
}

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

const assert = require('assert');
const net = require('net');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@

const common = require('../common');

if (!common.hasCrypto)
if (!common.hasCrypto) {
common.skip('missing crypto');
}

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

const assert = require('assert');
const { subtle } = require('crypto').webcrypto;
Expand Down

0 comments on commit 231ef4b

Please sign in to comment.