Skip to content

Commit

Permalink
deps: backport de1461b7efd from upstream v8
Browse files Browse the repository at this point in the history
Original commit message:

    Drop UniqueId from include/v8.h

    It's unused since March 2 2017 (https://chromium-review.googlesource.com/448539).
    This removes it assuming that leaving it in the header was an oversight.

    BUG=v8:5828

    Review-Url: https://codereview.chromium.org/2732803002
    Cr-Commit-Position: refs/heads/master@{#43605}

Ref: v8/v8@de1461b7efd

PR-URL: #12875
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
addaleax authored and jasnell committed May 28, 2017
1 parent 95c4b0d commit 19c0c07
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 27 deletions.
24 changes: 0 additions & 24 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -155,30 +155,6 @@ class GlobalHandles;
} // namespace internal


/**
* General purpose unique identifier.
*/
class UniqueId {
public:
explicit UniqueId(intptr_t data)
: data_(data) {}

bool operator==(const UniqueId& other) const {
return data_ == other.data_;
}

bool operator!=(const UniqueId& other) const {
return data_ != other.data_;
}

bool operator<(const UniqueId& other) const {
return data_ < other.data_;
}

private:
intptr_t data_;
};

// --- Handles ---

#define TYPE_CHECK(T, S) \
Expand Down
1 change: 0 additions & 1 deletion deps/v8/test/cctest/test-api-interceptors.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ using ::v8::String;
using ::v8::Symbol;
using ::v8::TryCatch;
using ::v8::Undefined;
using ::v8::UniqueId;
using ::v8::V8;
using ::v8::Value;

Expand Down
1 change: 0 additions & 1 deletion deps/v8/test/cctest/test-api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ using ::v8::String;
using ::v8::Symbol;
using ::v8::TryCatch;
using ::v8::Undefined;
using ::v8::UniqueId;
using ::v8::V8;
using ::v8::Value;

Expand Down
1 change: 0 additions & 1 deletion deps/v8/test/cctest/test-global-handles.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include "test/cctest/cctest.h"

using namespace v8::internal;
using v8::UniqueId;

TEST(EternalHandles) {
CcTest::InitializeVM();
Expand Down

0 comments on commit 19c0c07

Please sign in to comment.