perf_hooks: fix PerformanceObserver 'gc' crash

Signed-off-by: James M Snell <[email protected]> Fixes: #38412 PR-URL: #38414 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
nodejs · Apr 29, 2021 · 013fa59 · 013fa59
1 parent 4f6c4eb
commit 013fa59
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/lib/internal/perf/observe.js b/lib/internal/perf/observe.js
@@ -72,6 +72,8 @@ const kDeprecationMessage =
 const kTypeSingle = 0;
 const kTypeMultiple = 1;
 
+let gcTrackingInstalled = false;
+
 const kSupportedEntryTypes = ObjectFreeze([
   'function',
   'gc',
@@ -124,8 +126,11 @@ function maybeIncrementObserverCount(type) {
 
   if (observerType !== undefined) {
     observerCounts[observerType]++;
-    if (observerType === NODE_PERFORMANCE_ENTRY_TYPE_GC)
+    if (!gcTrackingInstalled &&
+        observerType === NODE_PERFORMANCE_ENTRY_TYPE_GC) {
       installGarbageCollectionTracking();
+      gcTrackingInstalled = true;
+    }
   }
 }
 

diff --git a/test/parallel/test-performanceobserver-gc.js b/test/parallel/test-performanceobserver-gc.js
@@ -0,0 +1,17 @@
+'use strict';
+
+require('../common');
+
+// Verifies that setting up two observers to listen
+// to gc performance does not crash.
+
+const {
+  PerformanceObserver,
+} = require('perf_hooks');
+
+// We don't actually care if the callback is ever invoked in this test
+const obs = new PerformanceObserver(() => {});
+const obs2 = new PerformanceObserver(() => {});
+
+obs.observe({ type: 'gc' });
+obs2.observe({ type: 'gc' });