-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag protection rules #1190
Comments
I tried to enable it, but quickly reverted the change, because:
|
|
Unfortunately, I don't think we have access to custom repository roles. At least I can't find the option in the org settings. |
It seems to be a feature specific to "Enterprise Cloud" GitHub. |
I can bring feedback to the team that worked on this |
There also doesn't seem to be a way to block creation of tags that don't match a pattern, but i guess that's consistent with branch protections. |
'*' ;) |
Hey folks 👋 I worked on this feature, and @MylesBorins was kind enough to share this issue with me. Just wanted to let y'all know that we're looking into applying the same treatment that branch protection has, of specifying a team/user to be able to bypass a tag protection rule. For context, our initial reasoning for not doing that was to instead rely on custom roles - but we've heard the feedback that OSS projects don't have that capability (as its an Enterprise Cloud feature [I do not know why and it bugs me]), so there's a gap here. I'll drop a note in here if/when that's available. Thanks for sharing your feedback 🙏 |
There's now https://github.blog/changelog/2023-04-17-introducing-repository-rules-public-beta/ in public beta. |
In beta.
Refs: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-tag-protection-rules
It's might be a good idea to turn this on. We'd need to make sure @nodejs/releasers would be still be able to create the tags for releases.
The text was updated successfully, but these errors were encountered: