Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Norwegian Bokmål #26

Closed
wants to merge 2 commits into from
Closed

Conversation

AmandaCameron
Copy link

Sorry for the huge number of changes. go-fmt had something to say about the rest of the code. :s

@nicksnyder
Copy link
Owner

Thanks for running gofmt!

It looks like your implementation and tests are incorrect. Both should be identical to Spanish according to the plural rules.

@AmandaCameron
Copy link
Author

Whoops. I'll fix that, the problem I had was that the variables were rather un-untiutively named for someone comfonr from a zero-state of the CLDR.

@nicksnyder
Copy link
Owner

Hey @AmandaCameron

Sorry, this kind of dropped off my radar. It looks like Travis builds fail with your changes, do you mind rebasing and cleaning this up?

I also noticed that you added two more languages to the implementation but did not update the tests or README. Could you do this?

@AmandaCameron
Copy link
Author

Whoops, sorry, I'll have to get to it later, as I'm pretty busy with some
RL stuff right now, but I had sketched out a couple of other labnguages
after no-nb to toy with it some more, and forgot by the time I fgot to
fixing it up again for the PR.

Feel free to close this and I'll open a new one when I have more time to
work on this stuff.

On Mon, Aug 17, 2015 at 11:16 PM Nick Snyder [email protected]
wrote:

Hey @AmandaCameron https://github.com/AmandaCameron

Sorry, this kind of dropped off my radar. It looks like Travis builds fail
with your changes, do you mind rebasing and cleaning this up?

I also noticed that you added two more languages to the implementation but
did not update the tests or README. Could you do this?


Reply to this email directly or view it on GitHub
#26 (comment).

@@ -266,6 +301,22 @@ var pluralSpecs = map[string]*PluralSpec{
},
},

// Macedonian
"mk": &PluralSpec{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macedonian?! neat.

@nicksnyder
Copy link
Owner

Closing this since @parkr submitted these languages in #36 and #35

@nicksnyder nicksnyder closed this Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants