-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Norwegian Bokmål #26
Conversation
Thanks for running gofmt! It looks like your implementation and tests are incorrect. Both should be identical to Spanish according to the plural rules. |
Whoops. I'll fix that, the problem I had was that the variables were rather un-untiutively named for someone comfonr from a zero-state of the CLDR. |
Hey @AmandaCameron Sorry, this kind of dropped off my radar. It looks like Travis builds fail with your changes, do you mind rebasing and cleaning this up? I also noticed that you added two more languages to the implementation but did not update the tests or README. Could you do this? |
Whoops, sorry, I'll have to get to it later, as I'm pretty busy with some Feel free to close this and I'll open a new one when I have more time to On Mon, Aug 17, 2015 at 11:16 PM Nick Snyder [email protected]
|
@@ -266,6 +301,22 @@ var pluralSpecs = map[string]*PluralSpec{ | |||
}, | |||
}, | |||
|
|||
// Macedonian | |||
"mk": &PluralSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macedonian?! neat.
Sorry for the huge number of changes. go-fmt had something to say about the rest of the code. :s