Resolve promise on close event

Amend test to use promise (would fail without the fix)
neverendingqs · Jun 17, 2019 · c04769d · c04769d
1 parent f162a85
commit c04769d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/extract.js b/lib/extract.js
@@ -46,7 +46,7 @@ function Extract (opts) {
 
   extract.promise = function() {
     return new Promise(function(resolve, reject) {
-      extract.on('finish', resolve);
+      extract.on('close', resolve);
       extract.on('error',reject);
     });
   };

diff --git a/test/extract-finish.js b/test/extract-finish.js
@@ -28,7 +28,7 @@ test("Only emit finish/close when extraction has completed", function (t) {
 
       delayStream._flush = function(cb) {
         filesDone += 1;
-        cb();
+        setTimeout(cb, 100);
         delayStream.emit('close');
       };
 
@@ -40,7 +40,7 @@ test("Only emit finish/close when extraction has completed", function (t) {
     unzipExtractor.on('error', function(err) {
       throw err;
     });
-    unzipExtractor.on('close', function() {
+    unzipExtractor.promise().then(function() {
       t.same(filesDone,2);
       t.end();
     });