refactor: fix some minor linter warnings #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheleriva
approved these changes
Aug 15, 2022
|
thank you 🙏 |
|
Oops, I should have marked it as draft, i pushed an extra refinement just now 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Now I'm not so sure if it's a good idea to propose these changes, as
repl.tsseems to be kinda "out of reach" for the type checker, and I might be introducing some difficult-to-detect problems until that is solved in the first place.The changes of this PR are merely cosmetic, but I find it a good thing to have a smaller amount of warnings when we run the linter :) .