Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve React Example #72

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Improve React Example #72

merged 3 commits into from
Aug 1, 2022

Conversation

mateonunez
Copy link
Collaborator

This PR fixes #71. I've added a script that builds Lyra before running Vite to fix it.

The React example was a little bit "reviewed".

image

This is what it looks like now.

I want to add new examples with other frameworks (or not) such as Vue, Svelte, and Vanilla JS.

@micheleriva
Copy link
Member

Thanks!

@micheleriva micheleriva merged commit ec240c6 into askorama:main Aug 1, 2022
@mateonunez mateonunez deleted the perf/example-with-react branch August 1, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React example can't find built Lyra package
2 participants