Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiting world while F3+L profiling is active crashes recursively. #83

Closed
James103 opened this issue Oct 29, 2021 · 2 comments
Closed

Exiting world while F3+L profiling is active crashes recursively. #83

James103 opened this issue Oct 29, 2021 · 2 comments

Comments

@James103
Copy link

Starting in Minecraft 1.17.1 (and possibly earlier), exiting the world while F3+L profiling is active crashes the game due to MC-235964.

However, when Fabric, Fabric API, and Not Enough Crashes 3.7.0 are installed, the crash becomes recursive, because the following exception is logged as a new profiler tick is attempted to be started while a profiler tick is already running.

To reproduce, follow the same reproduction steps as in MC-235964, which are copied below for your convenience.

  1. Start Minecraft.
  2. Create a new world or join a world.
  3. Press F3+L.
  4. Before the 10 seconds are up, exit the world by pressing Escape then clicking "Save and Quit to Title".
  5. Notice the resulting crash.

When fixing this, I suggest aborting the profiler early if the game crashes during profiling, so that the recursive crash can be avoided.

The following two crash reports were logged one second apart from each other, likely caused by the above reproduction steps.
crash-2021-10-25_16.54.57-client.txt
crash-2021-10-25_16.54.58-client.txt

@natanfudge
Copy link
Owner

Wow, awesome work tracking down these issues. I'll take a look at this soon.

@natanfudge
Copy link
Owner

Fixed in 3.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants