Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server task shouldn't assume webpack-dev-server is installed globally #28

Open
Daniel15 opened this issue Nov 28, 2016 · 0 comments
Open

Comments

@Daniel15
Copy link

Daniel15 commented Nov 28, 2016

All the dependencies for an app should be defined in its package.json file. However, rackt server assumes webpack-dev-server is installed globally, resulting in an error like this when running it if you don't have webpack-dev-server installed globally:

bash node_modules\rackt-cli\bin\rackt server
/c/src/react-autocomplete/node_modules/rackt-cli/bin/../tasks/server: line 3: webpack-dev-server: command not found

Instead of looking for a global webpack-dev-server, it should instead be executing ./node_modules/.bin/webpack-dev-server.

npm global packages are only supposed to be used for packages that operate globally and are not a dependency of the project itself (for example, create-react-app or yeoman). They're not the correct thing to use for something like webpack-dev-server which is a project devDependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant