Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Q] Remove matchValue() #73

Open
mtk3d opened this issue Feb 19, 2023 · 2 comments · May be fixed by #110
Open

[Q] Remove matchValue() #73

mtk3d opened this issue Feb 19, 2023 · 2 comments · May be fixed by #110

Comments

@mtk3d
Copy link
Contributor

mtk3d commented Feb 19, 2023

As I can see, the minimum version of PHP for latest Munus version is going to be 8.0 now 610f2c6. I can't see any reason to keep Munus's matchValue() now. PHP 8.0 has native match that works better in most cases in my opinion. I think it can be removed.
What do you think about it?
@akondas
Copy link
Member

akondas commented Feb 20, 2023

This is your code :D, can stay, can be removed, both options are ok with me 😉

@akondas
Copy link
Member

akondas commented Jun 2, 2024

I think I will remove match, I want to raise phpstan level and there is a lot of code to change which will not bring much value since PHP 8 has native match anyway and munus is no longer supporting php 7.4. Are we fine with that?

@akondas akondas linked a pull request Jun 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove match akondas/munus
2 participants
@akondas @mtk3d