-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Camera preview blank screen when using Skia Frame Processors #2935
Comments
Can you try setting your |
Does it render if you do not pass a |
Yup, it does render, but theres definitely some overhead due to the frameprocessor. |
Then it surely is the Overhead; yea I can see that it only runs at 3 FPS on this Android phone - is that an old phone? @wcandillon I think this is something we might need to investigate - it's either the |
I would like to check the performance of the |
Hi @mrousavy I dont think its an issue with the
Granted, the device I'm testing on is very old (Huawei P10 was released 2017). I was wondering if it could be due to these 2 runtime errors as seen in the logs, and would there be any ways to catch them.
@wcandillon What are some information specifically that i could provide about the phone? Also, how would i be able to check the performance of |
Ah interesting - i didnt read those logs my bad. It looks like an error, yep. Not sure if it's RN Skia related or VisionCamera related tho |
@wcandillon there's quite a few places in the codebase where RN Skia just swallows errors and logs them to the console (and returns null, or doesnt do anything) - I think throwing an Error (which will be propagated to JS) is better, especially in this case here. |
I too get a blank screen, maybe different from OP...when I start my Android device - after running a full build on EAS - I get an error on my device:
I thought to try my emulator and it complains about All I get is a white screen for my camera view.
I updated all the packages related to camera/frameprocessor/worklets, and now camera is working. EDIT: Actually, I am unable to use
|
I'm having a somewhat similar issue on OnePlus5 on 4.0.1. In my case the frame is partially displayed The camera preview is displayed correctly without any issues if I'm using useFrameProcessor: but once I switch to useSkiaFrameProcessor I get this: (notice the white space below and the L shaped black space |
What's happening?
Hi @mrousavy, thank you for the great work with this library.
However, I have been having issues with applying filters using useSkiaFrameProcessors, even when using the boilerplate provided in the docs.
I've tried two implementations
The camera preview ends up being just the filter, without any image. Please refer to the code and logs from both cases below.
I'm wondering whether this might be a hardware issue? I'm currently developing on an old Huawei P10 (released in 2017, Android 9). Ive had a friend run the app on a Samsung S23 Ultra and he did not encounter this issue.
Reproduceable Code
Relevant log output
Camera Device
Device
Huawei P10 (Android 9.0)
VisionCamera Version
4.0.5
Can you reproduce this issue in the VisionCamera Example app?
Yes, I can reproduce the same issue in the Example app here
Additional information
The text was updated successfully, but these errors were encountered: