Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debounce to push button #401

Open
lwYeo opened this issue May 7, 2023 · 13 comments
Open

Add debounce to push button #401

lwYeo opened this issue May 7, 2023 · 13 comments

Comments

@lwYeo
Copy link

lwYeo commented May 7, 2023

Missing feature

Debouncing does not seem to be present when pressing down the button.
Maybe adding around 100ms would be nice.

Justification

Sometimes the button "double-clicked" by itself, occurrence seem to be 1 in 10 or less (at least on my device).
Although it does not seem much, but it is rather annoying when it happens, especially when entering the last digit pin, causing unwanted "invalid pin" incidents.

@limpkin
Copy link
Contributor

limpkin commented May 7, 2023

there's actually already a debounce: https://github.com/mooltipass/minible/blob/master/source_code/main_mcu/src/INPUTS/inputs.c#L275, set to 100ms

@lwYeo
Copy link
Author

lwYeo commented May 7, 2023

there's actually already a debounce: https://github.com/mooltipass/minible/blob/master/source_code/main_mcu/src/INPUTS/inputs.c#L275, set to 100ms

Nice.
Since different unit may have different tolerances, would it be better if we can customise it?
If not can we increase to maybe 150ms-200ms, to reduce this issue further?

@limpkin
Copy link
Contributor

limpkin commented May 7, 2023

that's indeed a great idea!

@My1
Copy link
Contributor

My1 commented May 8, 2023

might this be the same reason why i sometimes dont get a wheel move when moving quickly through the numbers when trying to enter my pin?

@limpkin
Copy link
Contributor

limpkin commented May 9, 2023

not exactly no

@CGuy-1
Copy link

CGuy-1 commented May 29, 2023

I have this issue with my early unit, it seems the scroll wheel starts to do this after lots of use. This will just get worse and worse until the wheel stops working. I've replaced this unit with a new one that I think has a better scroll wheel installed. The new one doesn't exhibit any issues but it's only been 6 months.

@limpkin
Copy link
Contributor

limpkin commented May 30, 2023

Hello, are you saying you aren't able to click anymore?

@seviu
Copy link

seviu commented May 31, 2023

I got same problem

@limpkin
Copy link
Contributor

limpkin commented May 31, 2023

@seviu : can you expand on your symptoms? :)

@CGuy-1
Copy link

CGuy-1 commented May 31, 2023

@limpkin I can click but it will sometimes scroll at the same time. Just touching the scroll wheel lightly will sometimes make it scroll very quickly in one direction or the other. If I push down on the scroll wheel while clicking it works much better. This leads me to think the issue is hardware, the scroll wheel has failed and the contacts and/or wheel are lose. I have a very early unit and I use it all the time so perhaps the scroll wheel part isn't robust enough.

@limpkin
Copy link
Contributor

limpkin commented Aug 30, 2023

@CGuy-1 is this still happening? I could offer a device swap...

@CGuy-1
Copy link

CGuy-1 commented Sep 6, 2023

Yes, I suspect the scroll wheel contacts are broken or worn out. This is an early unit and I use it all the time so it may just need a new scroll wheel component. The battery doesn't hold a charge any more (and yes I've run the refresh several times), is it possible to replace it?

@limpkin
Copy link
Contributor

limpkin commented Sep 6, 2023

send me a quick email, we'll work something out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants