This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Read and propagate error from our iterator when decoding into slice #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't handling the error case when iterating through the Scanner gave an error. With gocql, it's especially important.
If we spot an error when decoding from the slice use case, we should return an error upstream
suhailpatel
force-pushed
the
make-sure-we-read-errors
branch
from
134ab64
to
fef7b5d
Compare
theninj4
approved these changes
Mar 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we spot an error when decoding from the slice use case, we should return an error upstream. This makes our decoding consistent between the slice and struct use case.