Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Add support for timestamp in Sentinel support #72

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

suhailpatel
Copy link
Member

@suhailpatel suhailpatel commented Sep 30, 2021

This PR adds a sentinel value for timestamp clustering columns. It chooses 1753-01-01 as the sentinel value. This is necessary because we can have clustering columns that are timestamps but certain stores (like Keyspaces) don't support the empty timestamp value as a clustering key

The decision to use 1st January 1753 (1753-01-01) as the minimum date value for a datetime in SQL Server goes back to its Sybase origins.

I've also made some methods public so we can use them elsewhere for other bits of internal code that check for sentinel values

@suhailpatel suhailpatel self-assigned this Sep 30, 2021
statement.go Show resolved Hide resolved
@leesio leesio merged commit 9805dd4 into master Oct 11, 2021
@leesio leesio deleted the clustering-sentinel-default-timestamp branch October 11, 2021 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants