Skip to content

Commit

Permalink
Add label Blacklisting
Browse files Browse the repository at this point in the history
  • Loading branch information
adamhf committed Dec 2, 2019
1 parent 2659077 commit e6bbae5
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 1 deletion.
1 change: 1 addition & 0 deletions api/redisfailover/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type RedisFailoverSpec struct {
Redis RedisSettings `json:"redis,omitempty"`
Sentinel SentinelSettings `json:"sentinel,omitempty"`
Auth AuthSettings `json:"auth,omitempty"`
LabelBlacklist []string `json:"labelBlacklist,omitempty"`
}

// RedisSettings defines the specification of the redis cluster
Expand Down
19 changes: 19 additions & 0 deletions api/redisfailover/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion operator/redisfailover/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,16 @@ func (r *RedisFailoverHandler) getLabels(rf *redisfailoverv1.RedisFailover) map[
dynLabels := map[string]string{
rfLabelNameKey: rf.Name,
}
return util.MergeLabels(defaultLabels, dynLabels, rf.Labels)

filteredCustomLabels := rf.Labels
for _, label := range rf.Spec.LabelBlacklist {
if _, ok := filteredCustomLabels[label]; ok {
delete(filteredCustomLabels, label);
r.logger.Debugf("Removing %s from labels as it is blacklisted", label)
}
}

return util.MergeLabels(defaultLabels, dynLabels, filteredCustomLabels)
}

func (w *RedisFailoverHandler) createOwnerReferences(rf *redisfailoverv1.RedisFailover) []metav1.OwnerReference {
Expand Down

0 comments on commit e6bbae5

Please sign in to comment.