Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ノート詳細 /notes/:id ページの直リンを踏むと404 #6533

Closed
rinsuki opened this issue Jul 12, 2020 · 5 comments
Closed

ノート詳細 /notes/:id ページの直リンを踏むと404 #6533

rinsuki opened this issue Jul 12, 2020 · 5 comments
Assignees
@syuilo
Labels
🐛Bug Unexpected behavior packages/backend Server side specific issue/PR

Comments

@rinsuki
Copy link
Contributor

rinsuki commented Jul 12, 2020

💡 Summary

image

📝 Steps to Reproduce

📌 Environment

misskey.io (12.41.1) / groundpolis.app(12.41.1-gp-3.10.0)
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Firefox/78.0
@rinsuki rinsuki added 🐛Bug Unexpected behavior packages/backend Server side specific issue/PR labels Jul 12, 2020
@syuilo
Copy link
Member

syuilo commented Jul 12, 2020

そこらへん変更した覚えないけどなんでだろ

@syuilo
Copy link
Member

syuilo commented Jul 12, 2020

あー
koa-routerアピデしたから何か影響したのかも

@mei23
Copy link
Contributor

mei23 commented Jul 12, 2020

@koa/router 9.1.0 以降で
APとWebで同じパラメータ付きルートを持っている時に
https://github.com/syuilo/misskey/blob/f8e06f12fd2922aa8d530868b2afb907a2686ae4/src/server/activitypub.ts#L65-L66
https://github.com/syuilo/misskey/blob/f8e06f12fd2922aa8d530868b2afb907a2686ae4/src/server/web/index.ts#L240-L241

後に処理するWebの方で取得できる値 (params.note) が :note みたいな値自身になってしまう。

@mei23
Copy link
Contributor

mei23 commented Jul 12, 2020

とりあえず9.0.1に戻すしかないかなと

@syuilo syuilo self-assigned this Jul 12, 2020
@syuilo syuilo closed this as completed in 364bd9a Jul 12, 2020
@rinsuki rinsuki mentioned this issue Jul 12, 2020
Closed
@mei23 mei23 mentioned this issue Dec 18, 2020
Closed
@mei23
Copy link
Contributor

mei23 commented Mar 21, 2021

syuilo/Misskey.old@4b13431 で上げたので壊れた

@mei23 mei23 reopened this Mar 21, 2021
@syuilo syuilo closed this as completed in 36bcaaf Mar 22, 2021
foggy1 pushed a commit to foggy-llc/pluskey that referenced this issue May 8, 2021
@syuilo
Resolve misskey-dev#6533
b4ae025
This was referenced Aug 17, 2021
Closed
Closed
snk-lab pushed a commit to snk-lab/misskey-kusa-note that referenced this issue Sep 24, 2021
@syuilo
Resolve misskey-dev#6533
5793140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syuilo syuilo

Labels
🐛Bug Unexpected behavior packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@syuilo @rinsuki @mei23