Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back caching of NotebookEditorInput if required in NotebookEditorInput class #207790

Open
DonJayamanne opened this issue Mar 15, 2024 · 0 comments
Assignees
Labels

Comments

@DonJayamanne
Copy link
Contributor

The caching of NotebookEditorInput has been removed.
This was added previously, probably for diff viewer.

Probably need to review why it was added and bring this back
Removed here #207745

Found that keeping multiple references of NotebookEditorInput was causing a few issues
The current approach is no better, but we fix the bugs

  1. If caching is indeed required, then we need to dispose them properly
  2. If caching is not required, we still need to dispose the NotebookEditorInput once we're done with this.

The latter can be a debt item for a few of us, once the first is done.

@rebornix /cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants