Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[completion] Don't suggest duplicates when uniqueItems: true #184

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Mar 23, 2023

However, I'm still thinking of clean way to handle boolean and null completions. I wonder why for these types information is written into types argument, instead of collector as completion directly?

private collectTypes(schema: JSONSchema, types: { [type: string]: boolean }) {

Edit: I see why it happens for object and array types, but I still don't understand why don't add completions for boolean and null directly in that function.

@aeschli aeschli self-assigned this Apr 24, 2023
@aeschli aeschli added this to the April 2023 milestone Apr 24, 2023
@aeschli aeschli merged commit 9fd55ab into microsoft:main Apr 24, 2023
@aeschli
Copy link
Contributor

aeschli commented Apr 24, 2023

Thanks @zardoy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants