Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High contrast compatibility #31205

Open
Kihara777 opened this issue Jan 31, 2024 · 10 comments
Open

High contrast compatibility #31205

Kihara777 opened this issue Jan 31, 2024 · 10 comments
Labels
Issue-Bug Something isn't working Product-Image Resizer Things regarding image resizing module Status-Reproducible This issue was reproduced by a maintainer

Comments

@Kihara777
Copy link

Microsoft PowerToys version

0.77.0

Installation method

PowerToys auto-update

Running as admin

Yes

Area(s) with issue?

Image Resizer

Steps to reproduce

I upgrade to the latest version, switch to contrast theme.

✔️ Expected Behavior

In my contrast theme, all the other powertoys window looks like:
image

❌ Actual Behavior

The Image Resizer window themed in light mode even I'm using contrast theme in system settings.
image

Other Software

No response

@Kihara777 Kihara777 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 31, 2024
@jaimecbernardo jaimecbernardo added the Product-Image Resizer Things regarding image resizing module label Jan 31, 2024
@jaimecbernardo
Copy link
Collaborator

I've just tried 0.78 on the "Night sky contrast theme" and this is what I get:

image

Perhaps a /bugreport will help?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 31, 2024
@Kihara777
Copy link
Author

Hi there!We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here? You right click on our system tray icon and just go to report bug. Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks! Report Bug

I failed to do that. It shows me "Your debug zip file saved to your desktop", but I didn't find it.
image

However I do found I'm using a sort of customized nightsky contrast theme, with color and wallpaper.
But the default NightSky works fine.
Here's the theme file:
G41 (ブラック).zip

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 31, 2024
@niels9001
Copy link
Contributor

@kiharra77 Would you mind upgrading to 0.78 to see if that resolves the issue?

@jaimecbernardo
Copy link
Collaborator

/needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Jan 31, 2024
@Kihara777
Copy link
Author

@kiharra77 Would you mind upgrading to 0.78 to see if that resolves the issue?

Yes, it still have the same problem.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 31, 2024
@jaimecbernardo
Copy link
Collaborator

Looks like you're getting pretty weird behavior. That does look like the Image Resizer has some bugs that were there some versions before.

Can you try to access the PowerToys.ImageResizer.exe file in your PowerToys installation folder? If you start the executable directly from that path (default machine is "C:\Program Files\PowerToys\PowerToys.ImageResizer.exe") and select a file, does it show the same issue? If you right click and check properties for the file, does it say it is 0.78.0 ?

image

@jaimecbernardo
Copy link
Collaborator

/needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Feb 1, 2024
@Kihara777
Copy link
Author

Looks like you're getting pretty weird behavior. That does look like the Image Resizer has some bugs that were there some versions before.

Can you try to access the PowerToys.ImageResizer.exe file in your PowerToys installation folder? If you start the executable directly from that path (default machine is "C:\Program Files\PowerToys\PowerToys.ImageResizer.exe") and select a file, does it show the same issue? If you right click and check properties for the file, does it say it is 0.78.0 ?

image

It doen't changes anything, but I found how to reproduce it manually.

Looks like this strange behaviour caused by a broken theme setup:

First, go to settings and apply a contrast theme
image
Everything looks fine.

Then go to theme page, change a cursor style, change the wallpaper, and save.
image

Close and open the settings again, enter theme page and you can now save this contrast theme, save it.
image

Use Shift + Alt + PrtSc to switch between the normal theme and saved contrast theme,
image
The Image Resizer window will themed in light mode, even after re-open the image resizer window.

I'm not quite sure if this behaviour is image resizer's bug now... But the image resizer is the only utility in powertoys that themed in light mode in this case.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 3, 2024
@crutkas
Copy link
Member

crutkas commented Feb 15, 2024

I can repro this with the provided steps.

Settings, Reg Preview, Host and Environment correctly apply where Image Resizer did not.
image

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Feb 15, 2024
@crutkas crutkas added Status-Reproducible This issue was reproduced by a maintainer and removed Needs-Team-Response An issue author responded so the team needs to follow up labels Feb 15, 2024
@crutkas
Copy link
Member

crutkas commented Feb 15, 2024

I'm on 0.78 as well

@ethanfangg ethanfangg added this to the PowerToys 0.80 milestone Mar 22, 2024
@ethanfangg ethanfangg added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Product-Image Resizer Things regarding image resizing module Status-Reproducible This issue was reproduced by a maintainer
Projects
Status: No status
Development

No branches or pull requests

5 participants