Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps]Re-evaluate workarounds after the upgrade to WASDK 1.4 #28423

Open
jaimecbernardo opened this issue Sep 7, 2023 · 4 comments
Open

[Deps]Re-evaluate workarounds after the upgrade to WASDK 1.4 #28423

jaimecbernardo opened this issue Sep 7, 2023 · 4 comments
Labels
Idea-Enhancement New feature or request on an existing product Priority-3 Bug that is low priority

Comments

@jaimecbernardo
Copy link
Collaborator

Description of the new feature / enhancement

The code contains quite some workarounds due to missing features in previous versions of Windows App SDK.
After #28310 (comment), the workarounds should be evaluated for removal.

Scenario when this would be used?

Code simplification.

Supporting information

No response

@jaimecbernardo jaimecbernardo added the Priority-3 Bug that is low priority label Sep 7, 2023
@jaimecbernardo jaimecbernardo added the Idea-Enhancement New feature or request on an existing product label Sep 7, 2023
@dongle-the-gadget
Copy link
Contributor

dongle-the-gadget commented Sep 7, 2023

That particular workaround mentioned still needs to be there, as AFAIK the Windows App SDK can't automatically handle title bar text foreground (most likely due to the need to support multiple UI frameworks like WPF)

@dongle-the-gadget
Copy link
Contributor

Yeah.

@dongle-the-gadget
Copy link
Contributor

Maybe the "immersive dark mode" workaround could be deleted? I didn't notice it on my own app using 1.4.

@ethanfangg ethanfangg added this to the PowerToys 0.80 milestone Mar 22, 2024
@ethanfangg ethanfangg added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Mar 22, 2024
@ethanfangg ethanfangg added this to the PowerToys 0.85 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Priority-3 Bug that is low priority
Projects
Status: No status
Development

No branches or pull requests

4 participants