Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all internal Task SyncContext agnostic #2505

Closed
pictos opened this issue Jun 10, 2024 · 2 comments
Closed

Make all internal Task SyncContext agnostic #2505

pictos opened this issue Jun 10, 2024 · 2 comments
Assignees
@alexbereznikov @pictos
Labels
breaking-change when the work will change the behavior or public APIs

Comments

@pictos
Copy link
Collaborator

pictos commented Jun 10, 2024

Raised on #2447, the long running task is sensitive to SyncronizationContext, that's devs can force that code execute inside the SyncronizationContext, and probably isn't what we want.

So in order to fix that we need to make sure our tasks will run under the TaskScheduler.Default.

The linked PR is one example, but we should investigate on our code base more places where we may have this issue.
@pictos pictos added the breaking-change when the work will change the behavior or public APIs label Jun 10, 2024
@pictos pictos mentioned this issue Jun 10, 2024
Merged
@alexbereznikov
Copy link

@pictos Yes please assign this one to me

@alexbereznikov alexbereznikov mentioned this issue Jun 13, 2024
Closed
@alexbereznikov
Copy link

@pictos Probably this issue should be closed due to #2515

@pictos pictos closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbereznikov alexbereznikov

@pictos pictos

Labels
breaking-change when the work will change the behavior or public APIs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexbereznikov @pictos