-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background colors from bitbar plugins do not work #792
Comments
Hmmm...there must be something up with the ANSI parser. I'll take a look. |
Any love for this issue? 😇 |
Thanks for the ping! I'll have a quick peek tonight |
Thanks. This'll be the weekend now. It looks like a parse error so I'll need to create a test case out of this for https://github.com/leaanthony/go-ansi-parser |
@ahmetb - after more looking at this, it seems bitbar didn't render it correctly anyway. I've fixed a small parse error which cleared it all up: I believe, based on what I'm reading in the standards, this is the correct output for those codes. If you disagree and have more insights, please let me know. Cheers. |
Should also mention that the bitbar rendering of the yahoo finance plugin in this thread is also a bit off. The screenshot on the plugin page looks like there are no background colours: |
I have customized it. I recommend trying with the link I provided. |
v2.1.7-beta
Repro: https://xbarapp.com/docs/plugins/Dev/Tutorial/ansi.sh.html
renders as
but it should render as
another repro is at https://github.com/ahmetb/dotfiles/blob/master/bitbar-plugins/yahoo_stock_ticker.1m.py renders as
whereas bitbar renders this as
The text was updated successfully, but these errors were encountered: